Commit graph

115 commits

Author SHA1 Message Date
Jonny Saunders
9074c1fac9
Use likes and shares totalItems on status creations and updates () 2024-10-28 04:55:18 +00:00
Matt Jankowski
e9b27852be
Reduce factory creation (14 -> 8) in ActivityPub::Activity::Block spec () 2024-10-15 13:51:52 +00:00
Jeong Arm
66b2bc1c84
Ignore error if mentioned account was not processable ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2024-10-02 08:08:02 +00:00
Matt Jankowski
5405bdd344
Remove unused E2EE messaging code () 2024-09-18 09:27:43 +00:00
Claire
c35ea59ee6
Fix security context sometimes not being added in LD-Signed activities () 2024-09-12 12:58:12 +00:00
Claire
ced5e853c7
Fix duplicate orderedItems in user archive's outbox.json () 2024-07-22 08:56:05 +00:00
Matt Jankowski
05342529dd
Reduce factory creation in AP activity move spec () 2024-07-19 08:31:34 +00:00
Emelia Smith
aa88aca0ad
Add optional OAuth application to reports () 2024-07-16 13:23:08 +00:00
Matt Jankowski
f1300ad284
Rename jobs/attachments rspec tag names () 2024-07-08 16:01:08 +00:00
Matt Jankowski
9cc4040308
Extract COMMENT_SIZE_LIMIT constant in AP::Activity::Flag class () 2024-06-10 15:23:55 +00:00
Claire
133d98fb25
Normalize language code of incoming posts () 2024-05-23 17:28:18 +00:00
Matt Jankowski
8349b45d60
Accept extra args that we wont verify in ap/activity/add_spec () 2024-03-13 08:46:11 +00:00
Claire
9fee5e8526
Merge pull request from GHSA-jhrq-qvrm-qr36
* Fix insufficient Content-Type checking of fetched ActivityStreams objects

* Allow JSON-LD documents with multiple profiles
2024-02-16 11:56:12 +01:00
Matt Jankowski
ed4939296a
Reduce RSpec/MultipleExpectations in ap/activity/create spec () 2024-02-16 07:43:00 +00:00
Matt Jankowski
15437e4ad9
Add context and before to lengthy tag manager spec examples () 2024-02-08 10:03:04 +00:00
Claire
1726085db5
Merge pull request from GHSA-3fjr-858r-92rw
* Fix insufficient origin validation

* Bump version to 4.3.0-alpha.1
2024-02-01 15:56:46 +01:00
Claire
087415d0fe
Add tests for processing statuses using bearcap URIs () 2024-01-25 11:13:36 +00:00
MitarashiDango
2c05b8a60d
Fix Undo Announce activity is not sent, when not followed by the reblogged post author ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2024-01-12 15:58:28 +00:00
Matt Jankowski
00341c70ff
Use Sidekiq fake! instead of inline! in specs () 2024-01-10 11:06:58 +00:00
Claire
2bf84b93d4
Fix media attachment order of remote posts () 2023-12-22 15:10:39 +00:00
Matt Jankowski
c99f88e1a8
Clean up of RSpec/LetSetup within spec/lib () 2023-12-21 11:19:56 +00:00
Matt Jankowski
973597c6f1
Consolidate configuration of Sidekiq::Testing.fake! setup () 2023-11-23 09:43:43 +00:00
Matt Jankowski
cfa14ec6d1
Fix Lint/EmptyBlock cop () 2023-11-07 09:11:04 +00:00
Claire
c0989b78f8
Fix incoming status creation date not being restricted to standard ISO8601 () 2023-11-06 09:28:14 +00:00
Claire
0337df3a42
Fix posts from threads received out-of-order sometimes not being inserted into timelines () 2023-11-02 14:58:37 +00:00
Claire
13688539bc
Fix processing LDSigned activities from actors with unknown public keys () 2023-10-20 10:45:46 +02:00
Matt Jankowski
f8afa0f614
Remove unused stub json ld context () 2023-10-16 15:38:27 +02:00
Claire
6c3c5bbbc3
Fix crash when processing Flag activity with no status () 2023-07-27 16:11:56 +02:00
Claire
1e3b19230a
Add stricter protocol fields validation for accounts () 2023-07-20 18:23:48 +02:00
Matt Jankowski
05f9e39b32
Fix RSpec/VerifiedDoubles cop () 2023-06-22 14:55:22 +02:00
Matt Jankowski
6c0e3f490a
Fix RSpec/MissingExampleGroupArgument cop () 2023-06-06 15:51:42 +02:00
Emelia Smith
19f9098551
Allow reports with long comments from remote instances, but truncate () 2023-05-22 13:15:21 +02:00
Matt Jankowski
710745e16b
Fix RSpec/ContextWording cop () 2023-05-04 05:49:08 +02:00
Matt Jankowski
3df665fd23
Fix Lint/ConstantDefinitionInBlock cop () 2023-05-03 10:32:30 +02:00
Nick Schonning
84cc805cae
Enable Style/FrozenStringLiteralComment for specs () 2023-02-22 09:55:31 +09:00
Nick Schonning
5116347eb7
Autofix Rubocop RSpec/BeEq () 2023-02-20 06:14:50 +01:00
Nick Schonning
4552685f6b
Autofix Rubocop RSpec/LeadingSubject () 2023-02-20 13:24:14 +09:00
Nick Schonning
5179c47087
Autofix Rubocops RSpec/ScatteredLet () 2023-02-20 11:17:41 +09:00
Nick Schonning
bd1d57c230
Autofix Rubocop RSpec/EmptyLineAfterSubject () 2023-02-20 02:46:00 +01:00
Nick Schonning
dbc6d7b276
Autofix Rubocop Lint/UnusedBlockArgument () 2023-02-20 02:45:50 +01:00
Nick Schonning
65ba0d92ef
Enable Rubocop RSpec/NotToNot () 2023-02-20 02:33:27 +01:00
Nick Schonning
5069769cbe
Autofix Rubocop Style/TrailingCommaInHashLiteral () 2023-02-18 23:33:41 +09:00
Nick Schonning
a7db0b41cd
Autofix Rubocop Lint/ParenthesesAsGroupedExpression () 2023-02-18 04:00:05 +01:00
Nick Schonning
634368c491
Autofix Rubocop Lint/SymbolConversion () 2023-02-18 03:23:49 +01:00
Nick Schonning
669f6d2c0a
Run rubocop formatting except line length () 2023-02-18 06:56:20 +09:00
Claire
0c9eac80d8
Fix unbounded recursion in post discovery ()
* Add a limit to how many posts can get fetched as a result of a single request

* Add tests

* Always pass `request_id` when processing `Announce` activities

---------

Co-authored-by: nametoolong <nametoolong@users.noreply.github.com>
2023-02-10 22:16:37 +01:00
Claire
8cf7006d4e
Refactor ActivityPub handling to prepare for non-Account actors ()
* Move ActivityPub::FetchRemoteAccountService to ActivityPub::FetchRemoteActorService

ActivityPub::FetchRemoteAccountService is kept as a wrapper for when the actor is
specifically required to be an Account

* Refactor SignatureVerification to allow non-Account actors

* fixup! Move ActivityPub::FetchRemoteAccountService to ActivityPub::FetchRemoteActorService

* Refactor ActivityPub::FetchRemoteKeyService to potentially return non-Account actors

* Refactor inbound ActivityPub payload processing to accept non-Account actors

* Refactor inbound ActivityPub processing to accept activities relayed through non-Account

* Refactor how Account key URIs are built

* Refactor Request and drop unused key_id_format parameter

* Rename ActivityPub::Dereferencer `signature_account` to `signature_actor`
2022-09-21 22:45:57 +02:00
Claire
1b4054256f
Fix crash when a remote Flag activity mentions a private post ()
* Add tests

* Fix crash when a remote Flag activity mentions a private post
2022-07-04 11:08:30 +02:00
Eugen Rochko
3917353645
Fix single Redis connection being used across all threads ()
* Fix single Redis connection being used across all Sidekiq threads

* Fix tests
2022-04-28 17:47:34 +02:00
Claire
0360135d4d
Fix PeerTube videos appearing with an erroneous “Edited at” marker ()
* Fix PeerTube videos appearing with an erroneous “Edited at” marker

PeerTube videos have an `updated` field equal to `published`.
When processing an incoming activity that has the same value for `updated` and
`published`, assume this doesn't represent an actual edit.

* Please CodeClimate
2022-04-26 21:25:26 +02:00