From 0b42cf29790c00de64069bf99d25e289af2283da Mon Sep 17 00:00:00 2001
From: Matt Jankowski <matt@jankowski.online>
Date: Mon, 18 Dec 2023 07:21:45 -0500
Subject: [PATCH] Opt out of `Rails/NegateInclude` cop (#28370)
---
.rubocop.yml | 5 +++++
.rubocop_todo.yml | 17 -----------------
2 files changed, 5 insertions(+), 17 deletions(-)
diff --git a/.rubocop.yml b/.rubocop.yml
index 2da7e361c..61cb1164b 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -115,6 +115,11 @@ Rails/SkipsModelValidations:
Rails/UnusedIgnoredColumns:
Enabled: false
+# Reason: Prevailing style choice
+# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsnegateinclude
+Rails/NegateInclude:
+ Enabled: false
+
# Reason: Some single letter camel case files shouldn't be split
# https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecfilepath
RSpec/FilePath:
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 2fa3a1ef6..030f31110 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -119,23 +119,6 @@ Rails/LexicallyScopedActionFilter:
- 'app/controllers/auth/passwords_controller.rb'
- 'app/controllers/auth/registrations_controller.rb'
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Rails/NegateInclude:
- Exclude:
- - 'app/controllers/concerns/signature_verification.rb'
- - 'app/helpers/jsonld_helper.rb'
- - 'app/lib/activitypub/activity/create.rb'
- - 'app/lib/activitypub/activity/move.rb'
- - 'app/lib/feed_manager.rb'
- - 'app/lib/link_details_extractor.rb'
- - 'app/models/concerns/attachmentable.rb'
- - 'app/models/concerns/remotable.rb'
- - 'app/models/custom_filter.rb'
- - 'app/services/activitypub/process_status_update_service.rb'
- - 'app/services/fetch_link_card_service.rb'
- - 'app/workers/web/push_notification_worker.rb'
- - 'lib/paperclip/color_extractor.rb'
-
Rails/OutputSafety:
Exclude:
- 'config/initializers/simple_form.rb'